[7.x] Fix rendering plain text only notifications #33803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to send plain text versions of notifications alongside html version was introduced in #33725. In #33781 I've made small fixes that allow to send plain text only notifications.
When the notification is sent, the view is built as an associative array using the
buildView()
method of theMailChannel
class. The array returned by this method is passed to theMailer
class, which parses this view array in theparseView()
method.However, when the notifications is rendered (for previewing in the browser), the view is built as a numeric array in the
render()
method. When it is passed to theMailer
class, it is parsed differently in theparseView()
method. If the notifications has the html view set, it is not a problem, the result is the same. But it the html view is null, the result ofparseView()
is different.This PR aims to fix this inconsistency, by building the view as an associative array in the
MailMessage::render()
method.