-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Move primary after collate #37815
Conversation
Ping @khalilst |
@driesvints , @Synchro I have checked the problem and it was related to 'Unsigned', 'Charset', 'Primary', 'Collate', 'VirtualAs', 'StoredAs', 'Nullable', However the current ordering in this PR has no problem, but putting the |
@driesvints Just give me an hour to fix this: #37820 . |
FWIW I've updated this PR to move it to after charset instead of collate. |
@driesvints |
We're gonna revert all of this. |
@driesvints I think these bugs are very tiny ones. Just need more test cases to prevent a similar situation. @taylorotwell Please consider this issue #33238 |
@khalilst we will give this a bit longer but we don't particularly care about DigitalOcean's problems. They aren't ours to fix. Complain to them. |
Thanks for merging |
@taylorotwell Thanks and I do agree. |
This simply changes the clause order in the MySQL grammar, and appears to fix #37811 in a similar way to the fix that resulted in the 8.48.1 release (which failed for me). I don't know what the definitive order of clauses should be, but this change fixes the issue I found.