Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix setUp and tearDown method visibility and casing. #41178

Merged
merged 1 commit into from
Feb 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Database/PruneCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ protected function artisan($arguments)
return $output;
}

public function tearDown(): void
protected function tearDown(): void
{
parent::tearDown();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class CanConfigureMigrationCommandsTest extends TestCase
{
protected $traitObject;

protected function setup(): void
protected function setUp(): void
{
$this->traitObject = $this->getObjectForTrait(CanConfigureMigrationCommands::class);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Integration/Database/EloquentMassPrunableTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function testPrunesSoftDeletedRecords()
$this->assertEquals(2000, MassPrunableSoftDeleteTestModel::withTrashed()->count());
}

public function tearDown(): void
protected function tearDown(): void
{
parent::tearDown();

Expand Down
2 changes: 1 addition & 1 deletion tests/Testing/AssertRedirectToSignedRouteTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function testAssertRedirectToSignedRouteWithRouteNameToTemporarySignedRou
->assertRedirectToSignedRoute('signed-route');
}

public function tearDown(): void
protected function tearDown(): void
{
parent::tearDown();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class InteractsWithDeprecationHandlingTest extends TestCase

protected $deprecationsFound = false;

public function setUp(): void
protected function setUp(): void
{
parent::setUp();

Expand Down Expand Up @@ -42,7 +42,7 @@ public function testWithoutDeprecationHandling()
trigger_error('Something is deprecated', E_USER_DEPRECATED);
}

public function tearDown(): void
protected function tearDown(): void
{
set_error_handler($this->original);

Expand Down
2 changes: 1 addition & 1 deletion tests/Testing/Concerns/TestDatabasesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function databaseUrls()
];
}

public function tearDown(): void
protected function tearDown(): void
{
parent::tearDown();

Expand Down
2 changes: 1 addition & 1 deletion tests/Testing/Console/RouteListCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function testDisplayRoutesForCliInVerboseMode()
->expectsOutput('');
}

public function tearDown(): void
protected function tearDown(): void
{
parent::tearDown();

Expand Down
2 changes: 1 addition & 1 deletion tests/Testing/ParallelTestingTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function callbacks()
];
}

public function tearDown(): void
protected function tearDown(): void
{
parent::tearDown();

Expand Down