Redis transaction is not closed when PSR-6 cache is used in combination with Redis store #47192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinssipenko I created this PR as a "potentially better" The idea is to open Redis transactions when we are sure that all values are serialized. |
|
Closing since PR is open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a test case addressing a case where the PSR-6 adapter in combination with the Redis store leads to the Redis transaction not being closed.
The problem is that if exception is thrown as part of
$cache->save($item);thenSymfony\Component\Cache\Adapter\Psr16Adaptereats the exception leading to the transaction not being closed inIlluminate\Cache\RedisStore:putMany()($this->connection()->exec();is never called). This later leads to read failures as Redis is returning an object that can't be unserialized.I don't know what would be the best way to fix this, thus I'm seeking guidance here.