[10.x] Prevent throw exception when cannot extract port from line #50041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedhosseiinii
force-pushed
the
prevent_throw_exception_when_cannot_extract_port_from_line
branch
from
cc1cf29 to
bc6802e
Compare
saeedhosseiinii
changed the title
|
Please add a thorough description to your PR and not just link to a previous issue or PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to #49927, when logging to stderr, certain strings will cause issues.
In handleProcessOutput of ServeCommand.php, the output is matched against certain strings. If these strings are found, additional logic is performed.
If strings that match the criteria are logged, it is possible that the strings are not what is expected, and will cause an exception
This pr solves this problem by checking that if it cannot extract the port from the line it does not enter the condition.