Move common method for a CapsuleManager to trait, this would reduce the ... #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crynobone
commented
Jul 15, 2014
crynobone
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | None |
| License | MIT |
| Doc PR | None |
- Move common method for a CapsuleManager to trait, this would reduce the requirement to produce new CapsuleManager for other component in the future (e.g: [Proposal] De-couple mail component a bit more #5032)
- Also remove duplicate "require-dev" component (when already explicitly declare in "require").
|
Nice job! Looks great and much more re-usable. Could it be that you forgot to declare Edit: if so then tests should break imo... perhaps we're not testing this enough. |
|
@GrahamCampbell he removed it from |
|
@driesvints I see that now. The diff doesn't show that part of the file on github. |
|
@driesvints fixed. |
|
Thanks for this @crynobone. 👍 |
…he requirement to produce new CapsuleManager for other component in the future (e.g: laravel#5032) Also remove duplicate "require-dev" component (when already explicitly declare in "require"). Signed-off-by: crynobone <[email protected]>
Signed-off-by: crynobone <[email protected]>
|
Updated to include some unit test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.