Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fluent string validation #54488

Closed
wants to merge 6 commits into from

Conversation

mrvipchien
Copy link
Contributor

This PR introduces a new fluent string validation, similar to the new fluent date (#53465) and numeric ([#54425]) validations.

Example Usage

use Illuminate\Validation\Rule;

public function rules()
{
    return [
        'foo' => [
            'required',
            Rule::string()->minLength(3)->maxLength(10)->alphaNumeric(),
        ],
        'bar' => Rule::string()->different('foo')->length(5)->uppercase(),
    ];
}

Comment on lines +255 to +263
/**
* The field under validation must be a valid A or AAAA record.
*
* @return $this
*/
public function activeUrl(): static
{
return $this->addRule('active_url');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this really be part of the string validation and not of a separate URI validation rule like the email validation rule?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants