Output console error when terminating due to memory usage #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #463 the memory limit was made configurable, however, when the memory limit is set too low (e.g. in my case more memory was being used than the default 64MB), Horizon will just fail silently.
For months Horizon was "broken" in one of my projects and I couldn't figure out why. No console output, no log output. The same is the case for #375.
This PR adds clear console output when
php artisan horizonterminates due to using more memory than configured (or the default 64MB)Before this PR:
After this PR:
I first just added the output without the change in
src/Console/HorizonCommand.php, that is still an option.The output is then: