Update runningProcesses to also include terminating processes #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningProcess() only checks $this->processes. But this doesn't include terminating processes, which are technically also running processes.
|
Tests are passing locally, are the unsuccessful checks a matter of re-running them? |
|
@nckrtl seems to specifically fail on the PHP 8.3 and L11 combo. Wondering why 🤔 |
|
It probably has something to do with Symfony Process 7.1.0 (which just released few hours ago). |
|
@nckrtl this is now fixed on 5.x, can you rebase? |
crynobone
approved these changes
May 31, 2024
|
We'll give it a shot. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative for #1433 which both solve #1450. The difference with this PR is that terminating processes will be included in the
runningProcesses()function, as suggested by @crynobone. Whenever there is a need to check for running processes elsewhere in the project the terminating processes will be included by default, instead of having to keep adding an additional check for terminating process like the other PR does #1433.