[3.0] New UI #522
Merged
[3.0] New UI #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
requested changes
Feb 26, 2019
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| return [ | |||
|
|
|||
| 'path' => 'horizon', | |||
There was a problem hiding this comment.
Let's also maybe add a descriptive comment above the setting like the other ones?
| {{ queue }} | ||
| </router-link> | ||
| </td> | ||
| </tr> |
| { | ||
| return [ | ||
| 'path' => config('horizon.path'), | ||
| 'timezone' => config('app.timezone') |
RobertBoes
suggested changes
Feb 27, 2019
| output += '<span>' + line + '</span>'; | ||
| }); | ||
|
|
||
| return output; |
There was a problem hiding this comment.
Since Lodash is used a lot, isn't it neater to use something like _.reduce?
var lines = _.split(exception, "\n");
return _.reduce(lines, (output, line) => {
return output += '<span>' + line + '</span>';
}, '');| padding: 0.75rem; | ||
| color: #fff; | ||
| background: $danger; | ||
| } |
There was a problem hiding this comment.
Missing a newline here
Suggested change
| } | |
| } | |
|
|
||
| .hljs-number, .hljs-literal { | ||
| color: #A291F5 !important; | ||
| } |
There was a problem hiding this comment.
Missing a newline
Suggested change
| } | |
| } | |
|
Merged the PR so you can open other PRs with your suggested changes @RobertBoes :) |
|
Those who are looking for night mode, here is how to enable it horizon/stubs/HorizonServiceProvider.stub Line 48 in 1ef9e37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an overhaul for the Horizon UI, it includes the following:
/horizon