[7.0] Merge default Passport configuration #1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PassportServiceProvider is lacking a
mergeConfigFrom
call, which breaks the key check inmakeCryptKey
unless one first copies the defaultconfig/passport.php
into their app's config directory. Copying the config should only be required when one wants to override the default values. I ran into this issue when trying to set my keys using environment variables in a new project.