[11.x] Fix getting/setting client scopes and grant types #1717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1716:
Additionally, this PR introduces a new
hasGrantType
method on the client model, similar to thehasScope
method it already has.If this is merged I plan to create a second PR against master to have both of these methods return true by default, and remove the relevant casts.
This then gives developers full control over how they want to implement these methods by simply extending the client model. The
skipsAuthorization()
method already works this way and (IMO) this is great way to do things.