Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pint.phar and Github Action #28

Closed
lucasmichot opened this issue Jun 23, 2022 · 8 comments
Closed

pint.phar and Github Action #28

lucasmichot opened this issue Jun 23, 2022 · 8 comments
Assignees

Comments

@lucasmichot
Copy link
Contributor

👋 there, congrats for the release @nunomaduro

Many code quality tools provide a phar version ( PHP-CS-Fixer, PHPMD, PHPStand, etc...)
Will pint also provide a .phar file for each release ?

Also what about having a laravel/pint-github-action, similar to https://github.com/OskarStark/php-cs-fixer-ga

@driesvints
Copy link
Member

@lucasmichot
Copy link
Contributor Author

I was meaning having the .phar in the release artefacts

@driesvints
Copy link
Member

That file is updated with every release. Unsure what you mean?

@lucasmichot
Copy link
Contributor Author

cf. https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/tag/v3.8.0
The .phar is part of the assets

image

@driesvints
Copy link
Member

Since this requires us to drag and drop the phar file manually with each release we're going to respectively decline as we don't want to put in that amount of work. You can still access the file from source.

@ju5t
Copy link

ju5t commented Jun 23, 2022

@driesvints something like this would do it for you: https://github.com/marketplace/actions/upload-to-release.

@lucasmichot
Copy link
Contributor Author

Drag and drop is way too 2010 😂

@driesvints
Copy link
Member

If anyone wants to PR an action like that we can consider it 👍

ablancobarreda added a commit to ablancobarreda/pint that referenced this issue Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants