New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Bump Dependencies and run Tests on skeleton #240

Merged

taylorotwell merged 5 commits into laravel:main from Jubeki:update

Jan 9, 2024

Contributor

Jubeki commented Jan 9, 2024

Replaces #232

Jubeki added 4 commits

January 9, 2024 11:02


          Bump dependencies

057e68c


          Run Tests on skeleton

cb8cb95


          phpdoc should use FQCN

031f70b


          Format files

57601f8

Contributor Author

Jubeki commented Jan 9, 2024

@nunomaduro I tested with the available options, but a change in the skeleton would be necessary (or removing the rule fully_qualified_strict_types would also be an option.)

Here the documentation of the rule fully_qualified_strict_types
https://cs.symfony.com/doc/rules/import/fully_qualified_strict_types.html

The failing tests are here, because I also added the skeleton to the test workflow.

Contributor Author

Jubeki commented Jan 9, 2024 •

edited

Loading

The changes in the skeleton would be regarding the imported middleware in app/Http/Kernel.php due to the namespace of the Middleware being a subnamespace of App\Http.

- \App\Http\Middleware\Authenticate::class,
+ Middleware\Authenticate::class,

See Results/changes here: https://github.com/Jubeki/laravel-code-style/actions/runs/7454679874/job/20282449218

Jubeki changed the title ~~Update Dependencies and run Tests on skeleton~~ [1.x] Update Dependencies and run Tests on skeleton

Jubeki changed the title ~~[1.x] Update Dependencies and run Tests on skeleton~~ [1.x] Bump Dependencies and run Tests on skeleton


          Disables fully_qualified_strict_types

74290ef

nunomaduro marked this pull request as ready for review

January 9, 2024 11:12

taylorotwell merged commit 2500d9d into laravel:main

6 checks passed

Jubeki deleted the update branch

January 9, 2024 11:31

renovate bot referenced this pull request in RadioRoster/backend


          chore(deps): update dependency laravel/pint to v1.13.10 (#118)

f807834

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [laravel/pint](https://laravel.com)
([source](https://togithub.com/laravel/pint)) | `1.13.7` -> `1.13.10` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/laravel%2fpint/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/laravel%2fpint/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/laravel%2fpint/1.13.7/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/laravel%2fpint/1.13.7/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>laravel/pint (laravel/pint)</summary>

###
[`v1.13.10`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v11310---2024-01-22)

[Compare
Source](https://togithub.com/laravel/pint/compare/v1.13.9...v1.13.10)

- Bump Dependencies and fix spacing issue by
[@&#8203;Jubeki](https://togithub.com/Jubeki) in
[https://github.com/laravel/pint/pull/244](https://togithub.com/laravel/pint/pull/244)

###
[`v1.13.9`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v1139---2024-01-16)

[Compare
Source](https://togithub.com/laravel/pint/compare/v1.13.8...v1.13.9)

- \[1.x] Replace custom phpdoc_align rule with php-cs-fixer option by
[@&#8203;Jubeki](https://togithub.com/Jubeki) in
[https://github.com/laravel/pint/pull/242](https://togithub.com/laravel/pint/pull/242)

###
[`v1.13.8`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v1138---2024-01-09)

[Compare
Source](https://togithub.com/laravel/pint/compare/v1.13.7...v1.13.8)

- \[1.x] Bump Dependencies and run Tests on skeleton by
[@&#8203;Jubeki](https://togithub.com/Jubeki) in
[https://github.com/laravel/pint/pull/240](https://togithub.com/laravel/pint/pull/240)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/RadioRoster/backend).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet