Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Update dev dependencies #234

Closed
wants to merge 2 commits into from
Closed

[3.0] Update dev dependencies #234

wants to merge 2 commits into from

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Nov 2, 2017

Updated mockery/mockery to ~1.0 and phpunit/phpunit to ~6.0.

PS: I've used this commit from laravel/framework to prevent failed tests.

@taylorotwell
Copy link
Member

Tests fail.

@carusogabriel
Copy link
Contributor Author

@taylorotwell The tests only failed because of PHPUnit 6.0 requires PHP 7.0. Should we drop support to 5.6?

@browner12
Copy link
Contributor

as long as we are supporting Laravel ~5.4, we need to continue supporting PHP 5.6. If PHPUnit requires 7.0, I think you're SOL on this one.

@carusogabriel
Copy link
Contributor Author

@browner12 So should I tagged it as Scout 4.0?

@browner12
Copy link
Contributor

you could try, but I highly doubt they're go to bump a full Major version just for some updated dev dependencies, unless you have a legitimate reason that they need to be updated.

@carusogabriel
Copy link
Contributor Author

@browner12 The only reason is to keep everything update, including test, as laravel/framework did. I’ll try, thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants