[4.x] Implemented fallback for PDO::quote method on QueryWatcher #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
May 27, 2021
src/Watchers/QueryWatcher.php
Outdated
| * Add quotes to string bindings. | ||
| * | ||
| * @param \Illuminate\Database\Events\QueryExecuted $event | ||
| * @param string $binding |
There was a problem hiding this comment.
Suggested change
| * @param string $binding | |
| * @param string $binding |
driesvints
reviewed
May 27, 2021
| { | ||
| try { | ||
| return $event->connection->getPdo()->quote($binding); | ||
| } catch (\PDOException $e) { |
|
@driesvints : Sorry driesvints, I did a last change. |
driesvints
changed the title
|
😅 I hope that last commit is accepted. I replaced In other way the release is buggy. |
|
@juanparati can you please do the changes I asked for above? Thanks |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will solve #1065.
Note: The fallback method may not constraint with all the target databases that ODBC is connected, It means that there is no way to know which charset, and quote symbol is the default used by the database, however the fallback method should represent an accurate query string for the most popular databases like mSQL, BigQuery or Snowflake.