Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ReflectionException when used with debugbar. #825

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

willvincent
Copy link
Contributor

I'm not familiar enough to know if there would be any further implications here, though given that a string is expected I can't imagine so... This resolves #824 and all existing tests are still passing.

@taylorotwell
Copy link
Member

Provide simple code for how to recreate this issue.

@willvincent
Copy link
Contributor Author

Not sure what sort of code you're looking for, for this.. fresh install of laravel, with telescope + barryvdh/laravel-debugbar

I have narrowed it down to the events collector in debugbar. When that's enabled the exception is thrown on the default welcome view. With my fix applied it's not thrown, and telescope appears to continue functioning normally with my fix in place.

Debugbar is apparently populating variables with an unexpected value, so maybe the fault lies entirely there...?

@taylorotwell taylorotwell merged commit 28101ca into laravel:2.0 Feb 7, 2020
@barryvdh
Copy link
Contributor

I'm using a callable, not a Closure: https://github.com/barryvdh/laravel-debugbar/blob/master/src/DataCollector/EventCollector.php#L66

 $events->listen('*', [$this, 'onWildcardEvent']);

Perhaps we should add \Closure::fromCallable($variables['listener']);?

@willvincent
Copy link
Contributor Author

That would probably make this a bit more accurate..

Screen Shot 2020-02-12 at 3 57 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReflectionException when ViewWatcher enabled and debugbar also running
3 participants