Fixed off-by-one bytes bug in qscintilla when using unicode #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we just grab self.parent().text is causes off by one errors in all downstream tokens, if you have unicode glyphs that are longer than one byte. Try adding © and see for yourself!
|
Using the latest version of PyQt5, I'm not getting any error when using the symbol. (I just updated the version, see #1243) However, I am getting suspiciously slow response time when editing a string in which that symbol exists. But your PR doesn't seem to affect it either way, it happens in both cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we just grab self.parent().text is causes off by one errors in all downstream tokens, if you have unicode glyphs that are longer than one byte.