-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add __lark_meta__ dunder #10
Conversation
It's a good start, but make sure the meta attributes are filled in correctly. |
Thanks. Sorry I forgot to mention, can you also make sure to test it with a Tree instance? (you can just add a rule to the grammar, and check its meta has attributes too) |
It's odd that the tests are passing.. how can that be if I didn't merge the Lark PR yet? |
I think this is not odd since I did not send the meta through the Tree. The token has the |
maybe i got it ... writing a test |
ok now it should fail. FYI on my machine it passes cause I have the |
Looks good! I'll merge it after next Lark release. |
@ernestoarbitrio The tests are still failling after releasing 1.1.4, any idea why? |
looking into it |
Now it should work |
Great, thank you for contributing! |
TBH I don't know how to test it better and write more meaningful test.
Any suggestion is more than welcome
FIXES #9