-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch -s|--stdengine #346
Conversation
ad2b130
to
53e1c72
Compare
Need to be added to the big list of options Lines 369 to 372 in 3d51aae
Also searching for Lines 454 to 461 in 3d51aae
Update: Addressed in f0d095b (Correct rerun docs, 2024-01-17). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somebody remarked that this should be also in the main (pdf) documentation. Otherwise, looks fine. (somebody was Yukai, as I now see :-))
elseif options["engine"] then | ||
checkengines = options["engine"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really for this pr but seeing this line: shouldn't in case of -e the checkengines variable set to the \cap of "engine" and the existing "checkengines" of a config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily - you can add -f
for force running with an 'unsuitable' engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- Sanity check
function check_engines(config)
if options["engine"] and not options["force"] then
-- Make a lookup table
local t = { }
for _, engine in pairs(checkengines) do
t[engine] = true
end
for _, engine in pairs(options["engine"]) do
if not t[engine] then
print("\n! Error: Engine \"" .. engine .. "\" not set up for testing with configuration \"" .. config .. "\"!")
print("\n Valid values are:")
for _, engine in ipairs(checkengines) do
print(" - " .. engine)
end
print("")
exit(1)
end
end
end
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I nevery really understood the use case for force :-) but yes, that makes it a little more complicated. But in case of asking for -e
without -f
: wouldn't it be more oportune to simply not do any tests for any of the "e" engines that are not in "checkengines" of a particular config rather calling it an error? Well maybe not, dunno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well we could drop --force
: it was there for some setup stuff which likely we no longer need (and I think -s
makes redundant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be done separate from the PR of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could I guess, and yes it should be done in a separate pr.
Co-authored-by: Yukai Chou <[email protected]>
No description provided.