-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code for #1632 #1637
base: develop
Are you sure you want to change the base?
code for #1632 #1637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo correction, two styling suggestions, and a question on usages like \refstepcounter{*ctr}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few typos. And we probably should check if some packages set @currentcounter and so perhaps need a guard too.
Co-authored-by: Yukai Chou <[email protected]>
Co-authored-by: Yukai Chou <[email protected]>
As far as I can see, the only files that set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a minor comment
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updatedI haven't added rollback
\c@*
is a new feature so only rollback would be to undefined, and\stepcounter
already has recent rollback for pre-socket versionssee #1632 for the enhancement