Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code for #1632 #1637

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

code for #1632 #1637

wants to merge 9 commits into from

Conversation

davidcarlisle
Copy link
Member

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

I haven't added rollback \c@* is a new feature so only rollback would be to undefined, and \stepcounter already has recent rollback for pre-socket versions

see #1632 for the enhancement

Copy link
Contributor

@muzimuzhi muzimuzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo correction, two styling suggestions, and a question on usages like \refstepcounter{*ctr}.

base/ltcounts.dtx Outdated Show resolved Hide resolved
base/ltxref.dtx Outdated Show resolved Hide resolved
base/ltcounts.dtx Outdated Show resolved Hide resolved
base/changes.txt Outdated Show resolved Hide resolved
Copy link
Member

@u-fischer u-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few typos. And we probably should check if some packages set @currentcounter and so perhaps need a guard too.

base/doc/ltnews41.tex Outdated Show resolved Hide resolved
base/doc/ltnews41.tex Outdated Show resolved Hide resolved
base/ltcounts.dtx Outdated Show resolved Hide resolved
base/ltcounts.dtx Outdated Show resolved Hide resolved
base/ltcounts.dtx Outdated Show resolved Hide resolved
base/ltcounts.dtx Outdated Show resolved Hide resolved
@FrankMittelbach
Copy link
Member

a few typos. And we probably should check if some packages set @currentcounter and so perhaps need a guard too.

As far as I can see, the only files that set \@currentcounterto something like #1 and not to an explicit string like "postnote" are our own, so I think we should be okay

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a minor comment

base/ltxref.dtx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants