Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node v22 #3472

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JamesLefrere
Copy link
Contributor

Picks commits from #3456

  • Updates engine and node types to v22, dropping support for older versions
  • Resolves issue with outdated unicorn-magic dependency by overriding it with a fixed version

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: f8967a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JamesLefrere JamesLefrere changed the title chore: update node 22 chore: update node v22 Jan 20, 2025
@holic
Copy link
Member

holic commented Jan 23, 2025

one question I have is whether the packages built under node 22 will still be usable in node 18 + 20

holic and others added 5 commits January 23, 2025 16:34
- `unicorn-magic` is abandoned and not compatible with node v22. Override it with pnpm to resolve to an [updated fork](SmushyTaco/unicorn-magic@09d6e7c) with minimal changes
@JamesLefrere
Copy link
Contributor Author

one question I have is whether the packages built under node 22 will still be usable in node 18 + 20

I have just tested this with the vanilla example with node 18, and it seems fine. Likewise, we only have the engines requirement on the root workspace, so all good there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants