test(store): fix tests after foundry update, move gas reports to separate tests #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrs
commented
May 14, 2023
| @@ -80,21 +41,18 @@ contract StoreCoreTest is Test, StoreReadWithStubs { | |||
| vm.expectEmit(true, true, true, true); | |||
| emit StoreSetRecord(StoreCoreInternal.SCHEMA_TABLE, key, abi.encodePacked(schema.unwrap(), keySchema.unwrap())); | |||
|
|
|||
| // !gasreport StoreCore: register schema | |||
| StoreCore.registerSchema(table, schema, keySchema); | |||
| IStore(this).registerSchema(table, schema, keySchema); | |||
There was a problem hiding this comment.
We don't have to cast to IStore here since this already extends the StoreMock contract, but I figured it makes it a bit more explicit to see what's going on here (and we don't care about gas cost in here because gas reports are moved to StoreCoreGas)
This was referenced May 14, 2023
holic
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814
Integrates the new
expectEmitbehavior introduced in feat(cheatcodes): MakeexpectEmitonly work for the next call foundry-rs/foundry#4920 by calling functions on a wrapper contract (IStore(this)) instead of the library directly (StoreCore) to trigger aCALL.Moves the gas reports to a separate test which still uses
StoreCore, since calling the methods on a wrapper contract increases gas cost (but for the Store library gas reports we're interested in the library cost, not the contract call cost)