Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

sqlalchemy support #13

Closed
wants to merge 2 commits into from
Closed

Conversation

dwa
Copy link

@dwa dwa commented Apr 1, 2017

This is cleaned up code developed at tobii.com (in collaboration with
knowit.se), which we use to connect from Superset (http://airbnb.io/superset/,
apache/superset#2531) to an Athena DB.

Usage:
athena://:@athena.us-east-1.amazonaws.com/?region_name=&s3_staging_dir=s3%3A//<staging_bucket_of_choice>

David Wallin added 2 commits April 1, 2017 02:42
This is cleaned up code developed at tobii.com (in collaboration with
knowit.se), which we use to connect from Superset (http://airbnb.io/superset/,
apache/superset#2531) to an Athena DB.

Usage:
athena://<user>:<password>@athena.us-east-1.amazonaws.com/?region_name=<region>&s3_staging_dir=s3%3A//<staging_bucket_of_choice>
@dwa
Copy link
Author

dwa commented Apr 1, 2017

Forgot to mention:

@laughingman7743
Copy link
Owner

laughingman7743 commented Apr 1, 2017

Thanks PR!

I would like you to write a test. PyAthenaJDBC's test uses pytest.
I think that the following PyHive's test will be helpful.

https://github.com/dropbox/PyHive/blob/master/pyhive/tests/sqlalchemy_test_case.py
https://github.com/dropbox/PyHive/blob/master/pyhive/tests/test_sqlalchemy_presto.py

PyAthenaJDBC's test also refers to PyHive's test.
Thanks,

@dwa
Copy link
Author

dwa commented Apr 1, 2017

Given the work on #14, are you still interested in this? Shall I work on some tests for this?

@laughingman7743
Copy link
Owner

Sorry, you do not need to write a test.
If you are interested in my implementation supporting SQLAlchemy, please connect to Superset with the following pull request branch.

#14

I do not use Superset, so I do not know if I can connect to Superset with my current implementation.
The connection string of SQLAlchemy is as follows. (Do not forget to quote access_key, secret_key and s3_staging_dir)

awsathena+jdbc://{access_key}:{secret_key}@athena.{region_name}.amazonaws.com:443/{schema_name}?s3_staging_dir={s3_staging_dir}&driver_path={driver_path}&...

Thanks,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants