fix(pool): always test connection on release to see if it's still viable #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/pool/bandaid
branch
2 times, most recently
from
58c2bcb to
541b26c
Compare
Signed-off-by: Austin Bonander <[email protected]>
abonander
force-pushed
the
ab/pool/bandaid
branch
from
541b26c to
3b5b575
Compare
|
I am afraid this breaks some code. Specifically the usage of a sqlite pool will result in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should alleviate some issues WRT cancellation (cc #563) as connections in an inconsistent state should not be recycled by
Pool.SQLx-next (0.6) will address the cancellation issue by ensuring connections remember all relevant state in order to resume where they left off.