query preparation works for custom types within CockroachDB transaction #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a consequence of the bug I've created earlier.
I use CockroachDB and issue an INSERT statement within an explicit transaction. The table has several columns with custom enum types. When I run a test it fails with the error from CockroachDB - "unimplemented: multiple active portals not supported".
The error hasn't reproduced while I used a pool and run multiple queries non transactionally.
This pull request replaces several
fetch_one/fetch_optionalcalls withfetch_many. These queries run to fetch custom Postgres type information during query preparation phase.fetch_many doesn't leave unclosed unnamed portal and fixes my transactional test pass against CockroachDB.