Added regexp support in sqlite #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VictorKoenders base changed to Also, can we have a flag in |
VictorKoenders
force-pushed
the
sqlite-regexp
branch
from
5dcb310 to
d3895c7
Compare
grgi
pushed a commit
to faccts/sqlx
that referenced
this pull request
Feb 14, 2023
* CHANGELOG: mention that users should upgrade CLI * Added regexp support in sqlite * Added a with_regexp function to sqliteconnectoptions * Fixed tests * Undo CHANGELOG.md change --------- Co-authored-by: Austin Bonander <[email protected]> Co-authored-by: Victor Koenders <[email protected]>
abonander
added a commit
that referenced
this pull request
Feb 18, 2023
* CHANGELOG: mention that users should upgrade CLI * Added regexp support in sqlite * Added a with_regexp function to sqliteconnectoptions * Fixed tests * Undo CHANGELOG.md change --------- Co-authored-by: Austin Bonander <[email protected]> Co-authored-by: Victor Koenders <[email protected]>
abonander
added a commit
that referenced
this pull request
Feb 21, 2023
* CHANGELOG: mention that users should upgrade CLI * Added regexp support in sqlite * Added a with_regexp function to sqliteconnectoptions * Fixed tests * Undo CHANGELOG.md change --------- Co-authored-by: Austin Bonander <[email protected]> Co-authored-by: Victor Koenders <[email protected]>
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
* CHANGELOG: mention that users should upgrade CLI * Added regexp support in sqlite * Added a with_regexp function to sqliteconnectoptions * Fixed tests * Undo CHANGELOG.md change --------- Co-authored-by: Austin Bonander <[email protected]> Co-authored-by: Victor Koenders <[email protected]>
|
I can only use SqliteConnectOptions, not SqlitePoolOptions, so how do I use |
|
Please, is there any ETA of having regexp in release? Or any other way how regexp can be enabled before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194
For a project I ended up implementing a custom
REGEXPimplementation for sqlite. I noticed sqlx did not have that, and #194 mentioned that it was not implemented yet.This is technically a breaking change if a user has already defined their own
REGEXPfunction. but sqlite's behavior is to simply overwrite the previous function, andsqlxdid not have aregexfeature yet (only insqlx-core).The current implementation is very strict. It only accepts UTF-8 columns in both the field and the REGEXP. In my system this has not been an issue.
I'm unsure where to add documentation on this, I'm guessing in the sqlite documentation?
I also took the liberty of bumping
libsqlite3-sys