Close open portals after receiving PortalSuspended #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used some printf debugging to determine that
PortalSuspended
message is received during a call towait_until_ready()
. This probably means thatwait_until_ready()
is being called at the wrong time? However, handlingPortalSuspended
here by sending anotherExecute
command, as the psql spec suggests, solves the multiple-portal issue we see with CockroachDB.@robo-corg and I are working on a similar patch that puts the handler in a less surprising place. But I'm opening this PR in case you're interested in a quick fix, or in case this helps us see how the protocol handling should be changed.
Fixes #933 and subsumes #944