feat: Add config command #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
Apr 15, 2024
| if cmd.Name() == "help" || cmd.Parent().Name() == "completion" { | ||
| cmd.DisableFlagParsing = true | ||
| // disable required flags when running certain commands | ||
| for _, name := range []string{ |
There was a problem hiding this comment.
This also fixes a bug where running ldcli completion bash would would flags which it shouldn't.
sunnyguduru
approved these changes
Apr 15, 2024
k3llymariee
approved these changes
Apr 16, 2024
cmd/config/config.go
Outdated
| fmt.Fprintln(cmd.OutOrStdout(), "called --list flag") | ||
| case viper.GetBool(SetFlag): | ||
| fmt.Fprintln(cmd.OutOrStdout(), "called --set flag") | ||
| case viper.GetBool(UnsetFlag): |
There was a problem hiding this comment.
should this be viper.GetString(UnsetFlag) instead?
* Find or create config file when reading values from it * Write config file after running config commands * feat: add config set flag (#177) * Adds support for ldcli config --set The set flag takes a key/value pair and writes them to the config file if they are relevant. It ignores arbitrary keys and for now only supports: * access-token * base-uri * Add config unset flag (#178) The unset flag takes a value removes it from the config file if it is relevant. It ignores arbitrary keys and for now only supports: access-token base-uri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
configcommand with three flags:ldcli config --list-- shows the values in the current config fileldcli config --set foo bar-- adds the key "foo" with value "bar" to the config file if it's a relevant keyldcli config --unset foo-- removes "foo" from the config file if it existsThis PR only sets up the command with the flags and doesn't do anything yet.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.