feat: add config unset flag #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unset flag takes a value removes it from the config file if it is relevant. It ignores arbitrary keys and for now only supports: access-token base-uri
sunnyguduru
approved these changes
Apr 15, 2024
k3llymariee
approved these changes
Apr 16, 2024
dbolson
added a commit
that referenced
this pull request
Apr 16, 2024
* Adds support for ldcli config --set The set flag takes a key/value pair and writes them to the config file if they are relevant. It ignores arbitrary keys and for now only supports: * access-token * base-uri * Add config unset flag (#178) The unset flag takes a value removes it from the config file if it is relevant. It ignores arbitrary keys and for now only supports: access-token base-uri
dbolson
added a commit
that referenced
this pull request
Apr 16, 2024
* Find or create config file when reading values from it * Write config file after running config commands * feat: add config set flag (#177) * Adds support for ldcli config --set The set flag takes a key/value pair and writes them to the config file if they are relevant. It ignores arbitrary keys and for now only supports: * access-token * base-uri * Add config unset flag (#178) The unset flag takes a value removes it from the config file if it is relevant. It ignores arbitrary keys and for now only supports: access-token base-uri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unset flag takes a value removes it from the config file if it is relevant. It ignores arbitrary keys and for now only supports:
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.