Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Attach the docker socket to the build container #399

Merged
merged 14 commits into from
Aug 16, 2024
Merged

fix: Attach the docker socket to the build container #399

merged 14 commits into from
Aug 16, 2024

Conversation

mike-zorn
Copy link
Contributor

@mike-zorn mike-zorn commented Aug 15, 2024 •
edited
Loading

This attaches the docker socket so that we can build docker images from the container that publishes releases.

Previously, the push of docker images was failing.

@mike-zorn mike-zorn requested a review from cwaldren-ld August 15, 2024 00:47
@mike-zorn mike-zorn requested review from dbolson and BehnH August 16, 2024 15:59
@mike-zorn mike-zorn merged commit 03e9697 into main Aug 16, 2024
5 checks passed
@mike-zorn mike-zorn deleted the fix-docker-publish branch August 16, 2024 16:05
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BehnH BehnH BehnH approved these changes

@cwaldren-ld cwaldren-ld Awaiting requested review from cwaldren-ld

@dbolson dbolson Awaiting requested review from dbolson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-zorn @BehnH