fix: Use ubuntu for the base image #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ubuntu as the base image. With alpine, because it has none of the standard shared libraries installed, we were running into the following issue.
This in turn, caused
ldcli
to not be executable from the image.By using ubuntu, standard c libraries are pre-installed, so we won't have this issue.
We probably do want to investigate the build process to see if we can produce an executable without external dependencies, but I think I'll need to work with @hoshsadiq on that.
Testing
Manually tested by building locally using the dockerfile. The error went away.