Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ubuntu for the base image #401

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mike-zorn
Copy link
Contributor

@mike-zorn mike-zorn commented Aug 16, 2024

Use ubuntu as the base image. With alpine, because it has none of the standard shared libraries installed, we were running into the following issue.

 ldd ldcli
     /lib/ld-linux-aarch64.so.1 (0xffffb7229000)
Error loading shared library libresolv.so.2: No such file or directory (needed by ldcli)
     libpthread.so.0 => /lib/ld-linux-aarch64.so.1 (0xffffb7229000)
     libdl.so.2 => /lib/ld-linux-aarch64.so.1 (0xffffb7229000)
     libc.so.6 => /lib/ld-linux-aarch64.so.1 (0xffffb7229000)
Error relocating ldcli: fcntl64: symbol not found
Error relocating ldcli: __res_search: symbol not found

This in turn, caused ldcli to not be executable from the image.

By using ubuntu, standard c libraries are pre-installed, so we won't have this issue.

We probably do want to investigate the build process to see if we can produce an executable without external dependencies, but I think I'll need to work with @hoshsadiq on that.

Testing

Manually tested by building locally using the dockerfile. The error went away.

@mike-zorn mike-zorn merged commit 92aec6e into main Aug 16, 2024
5 checks passed
@mike-zorn mike-zorn deleted the mikezorn/sc-253498/fix-ldcli-docker-image branch August 16, 2024 22:30
hoshsadiq added a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants