Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish docker image #99

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

sunnyguduru
Copy link
Contributor

@sunnyguduru sunnyguduru commented Mar 30, 2024

  • add docker image goreleaser info

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

Copy link

This pull request has been linked to Shortcut Story #238534: Publish docker image.

@sunnyguduru sunnyguduru requested a review from dbolson March 30, 2024 00:03
@sunnyguduru
Copy link
Contributor Author

This is very simple but I want to see if we can get an image generating this way first. There will be some trial and error.

@sunnyguduru sunnyguduru marked this pull request as ready for review March 30, 2024 00:07
Copy link

@InTheCloudDan InTheCloudDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding arm64 to both this and ld-find-code-refs but that could be a followup.

@sunnyguduru
Copy link
Contributor Author

Might be worth adding arm64 to both this and ld-find-code-refs but that could be a followup.

Oh sounds good. I can add that next

@sunnyguduru sunnyguduru merged commit a294ce0 into main Apr 4, 2024
@sunnyguduru sunnyguduru deleted the sunny/sc-238534/publish-docker-image branch April 4, 2024 16:33
This was referenced Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants