Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React/Redux Implementation #10

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

diegodesouza
Copy link

No description provided.

…lists, and also no longer are editable after creating new lists.
remove unused module, fix styling.
Remove unused code. TODO: implement firebase perhaps.
@superchris
Copy link
Member

Diego,

I've reviewed your submission and wanted to give you my impressions. I was able to easily start up the app. I was able to add a list, and add items to it. Next we'd love to see if you can make items a bit more detailed: we'd like each item to have a price, name, and SKU. Adding an item might bring up a form with a field for each attribute in this case.

If you'd like to continue on with this application, I'd be happy to give your submission another look. We've scheduled a few interviews, and based on the outcome of those we may or may not do more interviews for the first pair of apprentices. Regardless, we plan to hire a second pair of apprentices in a month or tow and would be happy to consider your submission for the second pair as well.

@diegodesouza
Copy link
Author

@superchris This took me longer than expected. You should have a working version soon. Thanks for your patience.

@diegodesouza
Copy link
Author

@superchris I have pushed my latest changes, let me know what you think. 🤓

@diegodesouza
Copy link
Author

diegodesouza commented Apr 24, 2016

Added tests for the validate function. Fixed tests for reducers. 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants