Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor menu system #60

Closed
laurb9 opened this issue Aug 7, 2016 · 1 comment
Closed

Refactor menu system #60

laurb9 opened this issue Aug 7, 2016 · 1 comment
Assignees
@laurb9
Labels
improvement
Milestone
v1.2

Comments

@laurb9
Copy link
Owner

laurb9 commented Aug 7, 2016

Menu system definition and operation is confusing.

If we remove the dependency on AVR (#57) and therefore the restricted RAM usage, the menu can be refactored to be easier to define and use. Maybe move HID handling inside menu instead of in the main .ino
laurb9 added a commit that referenced this issue Aug 8, 2016
@laurb9
Moved displayMenu into menu.cpp #60
01d5aff
laurb9 added a commit that referenced this issue Aug 8, 2016
@laurb9
Combine all input sources into AllHID #60
a9012c0 
Implemented an aggregator to avoid repeating read() / clear() for each
input source individually.
laurb9 added a commit that referenced this issue Aug 8, 2016
@laurb9
Store and query last event in AllHID #60
363bb55 
The "event" temporary variable is unnecessary in user code.
@laurb9 laurb9 self-assigned this Aug 8, 2016
@laurb9 laurb9 added this to the v1.2 milestone Aug 8, 2016
@laurb9
Copy link
Owner Author

laurb9 commented Aug 8, 2016

Done. Will need a second round later to address the callbacks and special input handling for positioning and pano.

@laurb9 laurb9 closed this as completed Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurb9 laurb9

Labels
improvement
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
1 participant
@laurb9