Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make enable logic state configurable #75

Closed
laurb9 opened this issue Jan 27, 2019 · 0 comments
Closed

Make enable logic state configurable #75

laurb9 opened this issue Jan 27, 2019 · 0 comments
Labels
improvement
Milestone
1.1.4

Comments

@laurb9
Copy link
Owner

laurb9 commented Jan 27, 2019

Looks like my decision made in #5 to use the ENABLE pin over the SLEEP pin in the Pololu examples has caused a certain amount of confusion (#51 #67 . Besides the wiring issues, ENABLE is active LOW in most boards but active HIGH in at least one, while SLEEP behavior of active HIGH is more consistent.

  1. Make the enable active state configurable (maybe something like setEnableActiveState(bool))
  2. Default to controlling SLEEP pin (this is a breaking change as it reverses the previous logic)
  3. Add a 1-2µs delay when enabling the driver (exact timing depends on board)
  4. see if that causes any problems with multiple boards hooked to the same SLEEP line.
@laurb9 laurb9 added this to the 1.1.4 milestone Jan 27, 2019
@laurb9 laurb9 mentioned this issue Jan 27, 2019
Closed
laurb9 added a commit that referenced this issue Jan 27, 2019
@laurb9
Allow setting of active state for the enable pin.
52bd50c 
- Default is active HIGH (as if SLEEP is used)
- For ENABLE, call `setEnableActiveState(LOW)`

Addresses issue #75
@laurb9 laurb9 closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
1 participant
@laurb9