We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The order of parameters is wrong between the #define and the use of the macro, so the macro expansion is wrong.
In BasicStepperDriver.h you have..
/* * calculate the step pulse in microseconds for a given rpm value. * 60[s/min] * 1000000[us/s] / microsteps / steps / rpm */ #define STEP_PULSE(steps, microsteps, rpm) (60.0*1000000L/steps/microsteps/rpm)
But in BasicStepperDriver.cpp you use it as:
163 step_pulse = cruise_step_pulse = STEP_PULSE(rpm, motor_steps, microsteps); 238 t = steps * STEP_PULSE(rpm, motor_steps, microsteps);
The text was updated successfully, but these errors were encountered:
(bug) fix parameter order in STEP_PULSE macro (#86)
24244c9
This didn't affect calculations because all the parameters are divisors.
laurb9
No branches or pull requests
The order of parameters is wrong between the #define and the use of the macro, so the macro expansion is wrong.
In BasicStepperDriver.h you have..
But in BasicStepperDriver.cpp you use it as:
The text was updated successfully, but these errors were encountered: