Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Spell check #275

Closed
4 of 8 tasks
alexdevero opened this issue Mar 7, 2018 · 55 comments
Closed
4 of 8 tasks

Feature Request: Spell check #275

alexdevero opened this issue Mar 7, 2018 · 55 comments
Labels
backlog We'll get to it... eventually... desktop All desktop platforms enhancement Feature requests and code enhancements

Comments

@alexdevero
Copy link
Contributor

alexdevero commented Mar 7, 2018

Since Joplin is note taking app having some option to check the text for spelling errors could be a nice feature.

Operating system

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Application

  • Desktop
  • Mobile
  • Terminal
@alexdevero alexdevero changed the title Feature Request: Spellcheck Feature Request: Spell check Mar 7, 2018
@laurent22 laurent22 added the enhancement Feature requests and code enhancements label Mar 7, 2018
@nhoening
Copy link

+1

@diogogomes
Copy link

Consider to add multiple language checker. Thanks

@xelcho
Copy link

xelcho commented Sep 18, 2018

+1

@alexdevero
Copy link
Contributor Author

The electron-spell-check package might be useful.

@noamgu
Copy link

noamgu commented Sep 29, 2018

+1

@kelseyurgo
Copy link

+1

1 similar comment
@marc0der
Copy link

+1

@diogogomes
Copy link

Please, use the 👍 icon instead of write +1 to not overflow the mail subscribers of this issue.

Thank you

@laurent22
Copy link
Owner

Another thing is that +1s are ignored during the development process. There could be a thousand of them and still the issue would be ignored. However thumbs up are used to determine what issues are the most popular so that's what you need to do to push the issue forward.

@marc0der
Copy link

marc0der commented Feb 2, 2019

@diogogomes @laurent22 Totally agree and point taken. The issue does remain that you have 27 thumbs up for this issue at this point with no action taken or feedback given since the 7th March 2018 (almost a year ago).

I'm sure many folks (including myself) would love to help get this feature built but we would probably need some guidance regarding how to do this.

@blueorignal
Copy link

@laurent22, following on from @marc0der, would it be helpful if the community provided you with dictionaries for different languages? Otherwise, I too would like to assist implement the spell check functionality, but would require inputs as to what you need to help make this happen. Irrespective about your decision re: spell checking, I wanted to say a big thank you for your work on Joplin. Joplin has become one of my most critical programs and substantially improved my general workflow.

@laurent22
Copy link
Owner

If we were to implement this we would use the built-in system dictionaries, if at all possible.

@blueorignal
Copy link

If we were to implement this we would use the built-in system dictionaries, if at all possible.

Thank you. That makes perfect sense.

@laurent22
Copy link
Owner

Blocked by #1128 because Ace Editor doesn't support spell checking.

@blueorignal
Copy link

Thank you for investigating. Much appreciated.

@CollinChaffin
Copy link

As much as I've been ranting about how great Joplin is and quickly has become my go-to note app overtaking onenote & evernote, it's funny that spell-check is like air you just assume it's there and sometimes you forget about it as much as I need spell-check it wasn't until I hit a really tough doc and knew I needed that magic "right-click to fix" that we've all becomed so accustomed to, and found unlike any other recent app - it was not there! :(

I chucked as I typed this comment and sure enough needed to right-click-to-fix twice. Point is this is a pretty basic feature nowadays and it looks like there is even a pre-built electron spellcheck library that could be used, so can I as as someone who is not an electron app dev but does other dev work as to what the major hurdles are on getting this implemented? Reading above I don't see many specifics on why is CANNOT be done and hasn't been in a year, so is it just a matter of resources or ?

@laurent22
Copy link
Owner

The editor we use doesn't support the built in Electron spell checking so something custom would need to be built.

@dddjjjbbb
Copy link

Just a note, in case it's of any interest to any of you in the thread. Given the Electron package doesn't seem to be a viable option and this feature isn't part of the current road map, you can open any note in question in an external editor via the button to the left of the tag icon (in my case, CotEditor) and run a spell check there. It's the best solution I found for the time being. Hope that helps.

@blueorignal
Copy link

@dddjjjbbb thank you. That's a simple, workable solution.

@flemay
Copy link

flemay commented Apr 4, 2019

@CollinChaffin I, too, thought spellcheck would come by default and having the workflow: write your document in Joplin -> copy into another app to fix the mistakes -> copy back to Joplin is not ideal.

@dddjjjbbb's suggestion works although I am not sure if the file stays on disk indefinitely (i.e: ~/.config/joplin-desktop/tmp/eb94e8d92e23f72fa8fe153b9fa1f72c.md)

UPDATE: Actually the file gets deleted after you stop watching it from Joplin. :)

@kign
Copy link

kign commented Jul 29, 2019

Indeed, like many others pointed out, spell check is a must-have. There are multiple other problems I encountered in a few days I was trying to use it, but spellcheck is a deal breaker for me.

@deljones
Copy link

deljones commented Aug 6, 2019

I love Joplin, use it for everything and yes the absence of a spell checker is a shame so what I do , as a Windows user, is to use NotePad++ and then in Joplin point to an external. I have installed the spell check plugin for NotePad++ and asked the plug in to use Windows Native spell checking. It works perfectly for me. My spelling is atrocious at best. Click save in NotePad++ and Joplin picks it up. Nice, not ideal but as a work around I find it useful.

Just my thoughts

@vb0
Copy link

vb0 commented Aug 16, 2019

Funny thing is that with Joplin I've been trying to move away from NotePad++ after I've got tired from having my sessions saved FINE every day for weeks until BANG at some point it'll forget everything (usually after an update or possibly after a hasty shutdown with "this program is preventing windows from shutting down would you like to close it"). And then I had to hunt for a bunch of files opened from I don't even remember where and some drafts I've never saved. But who knows, maybe as just a spell-checking editor npp would work well after all.

@ghost
Copy link

ghost commented Sep 29, 2019

+1

@Tiger862000
Copy link

Tiger862000 commented Jun 17, 2020

If you want a spell and grammar checker with wide support for many languages and already a broad ecosystem, then have a look at “LanguageTool”. It has besides fool-proof spell check also an inbuilt grammar checks, all for free and open source. Code can be found here: https://github.com/languagetool-org/

@ashiquelal
Copy link

Anyone know of an easy work-around or 3rd party app on Mac/Linux that could be used to spellcheck in real time?

Typora, open the Note with the "Edit in external Editor". Typora has a great Spellcheck, but you can use every other Markdown Editor, @EricB10

@laurent22 Would it be possible for you to combine one of the open source markdown editor so that it provides the spell checking too? Something like Mark Text which is semi-WYGIWYS ?

@jmacmichael
Copy link

Anyone know of an easy work-around or 3rd party app on Mac/Linux that could be used to spellcheck in real time?

On Linux, I'm using terminal + the aspell utility as the external editor. This makes Ctrl-E go to a terminal-based spell check window, not an editor per se. But as I don't use an external editor for anything else, this works well for me. The configuration is (update for your terminal prog):

Text editor command path: /usr/bin/gnome-terminal
Text editor command args: -- /usr/bin/aspell -c

This opens gnome-terminal with the params (see gnome-terminal help) to open an aspell session to check the file that Joplin gives it. Then I fix any spelling mistakes inside aspell and it saves the file. Et voila.

@nuke-web3

This comment has been minimized.

@Abhi18022
Copy link

+1

@karma12gaming
Copy link

I have terrible spelling. Even a basic spell check would be greatly appreciated as I primarily use Joplin for academic notation.

@hypergig
Copy link

I have never seen a github issue with so many thumbs up before... this is a must have.

Throw a feature bounty on this, I would easily donate $100 bucks to the cause and I only discovered joplin 12 hours ago.

Screenshot from 2020-08-19 09-52-47

@itpropaul
Copy link

+1

@laszukdawid
Copy link

Hey @laurent22 ,
At least for me it still isn't clear whether you/anyone is working on this. You mentioned that the issue lays on Joplin's dependency and a proper way would be to rewrite the editor. That's been a year ago. The original issue post has some ticks but I'm not sure when were those done.

Just checked that Monaco-editor has open spell checking feature request (microsoft/monaco-editor#1977) but there's little activity on it.

Given the interest in the issue, could I ask to be more explicit with the progress/state? There are many devs using Jopling so maybe someone could contribute. I'd be happy to know if this is something I could help with :)

@hypergig
Copy link

I notice that you can open the devtools in Joplin, is there a javascript hack that we can use to support spellcheck? Like copy / paste ye giant block of js into the console sorta scrapy fix I am looking for here...

@hypergig
Copy link

🛡️ I pledge $100 bucks to this feature

@laurent22 laurent22 mentioned this issue Oct 9, 2020
29 tasks
@stale
Copy link

stale bot commented Oct 12, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Oct 12, 2020
@tinchi
Copy link

tinchi commented Oct 13, 2020

👍

@stale stale bot removed the stale An issue that hasn't been active for a while... label Oct 13, 2020
@zrml
Copy link

zrml commented Oct 13, 2020

This is important IMO and deserves attention for long-term product consideration by prospect & survivability.
Thanks

@laurent22 laurent22 added backlog We'll get to it... eventually... desktop All desktop platforms labels Oct 13, 2020
@laurent22
Copy link
Owner

Just an update - thanks to the effort of @CalebJohn to replace the old editor with a new one, it's now technically possible to add spell checking. It doesn't mean it's going to be done right away but at least we got closer to eventually have spell checking.

@hychrisli

This comment has been minimized.

@ghost
Copy link

ghost commented Nov 9, 2020

So yeah I started using this a few months ago, and spell checking is the main thing I miss rn

@laurent22
Copy link
Owner

After nearly 3 years and 340 votes, this feature is finally implemented! Please have a look at the announcement post, in particular for information on how to enable it in the Markdown Editor: https://www.patreon.com/posts/44328867

@alex-rusakevich
Copy link

If you want a spell and grammar checker with wide support for many languages and already a broad ecosystem, then have a look at “LanguageTool”. It has besides fool-proof spell check also an inbuilt grammar checks, all for free and open source. Code can be found here: https://github.com/languagetool-org/

+1 for LanguageTool. Chrome default spell checker doesn't have Belarusian language support, but LT has. Besides that, LT is far more advanced than the default Chrome spell checker, as stated above.

I like Joplin, and I'd like to write everything using it, but absence of LT makes me use Google Docs or Zettlr to write something serious like books, poems and news articles.

@ttrakker
Copy link

Will this be implemented? Thinking this is a deal breaker for me and joplin now.

Repository owner locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog We'll get to it... eventually... desktop All desktop platforms enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests