Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fixes #10253: Move accessibility focus to the first note action menu item on open #11031

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Sep 11, 2024

Summary

This pull request fixes #10253 by moving focus from the note action menu toggle to the first item in the note action menu when the menu opens. To simplify this, the popup menu code is moved to a separate file.

See also #10333.
Edit: Related to #11661.

Testing plan

Existing tests that apply to this pull request:

  • screens/Note.test.tsx: Verifies that the menu can be opened and items in the menu can be activated.

Manual testing:

  • Web (Firefox):
    1. Navigate to the note action button with tab.
    2. Press enter.
    3. Verify that the note action menu is visible.
    4. Navigate to the "tags" button by pressing tab.
    5. Verify that the tab order was "Attach", then "Draw picture", then "Tags".
    6. Press enter.
    7. Verify that the menu opens.
  • Android 13:
    1. Enable TalkBack.
    2. Move TalkBack focus to the note action menu button.
    3. Navigate to "voice typing".
    4. Verify that the focus order is "Attach" > "Draw picture" > "Share" > "Voice typing...".
    5. Activate "voice typing" by double-tapping.
    6. Verify that the menu closes.
      • Follow-up issue: Focus jumps to the first item in the note. The voice typing heading should auto-focus.

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms accessibility Related to accessibility labels Sep 11, 2024
@laurent22 laurent22 merged commit ea61bfc into laurent22:dev Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Screen reader focus stays on the open menu button when the note actions menu is opened
2 participants