Chore: Desktop: Wait for plugins to load before running certain plugin-related tests #11224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2024
| const mainScreen = new MainScreen(mainWindow); | ||
| await mainScreen.waitFor(); | ||
| await startupPluginsLoaded; |
There was a problem hiding this comment.
Move to correct test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request waits for startup plugins to load before running certain Playwright tests that depend on plugins. This should reduce test flakyness.
Notes:
settings > should be possible to navigate settings screen tabs with the arrow keyssometimes failed because it expected the backup plugin to have a tab in settings, but that plugin hadn't loaded yet.pluginApi.spec.tstests similarly didn't wait for startup plugins to load, which may also cause test failures.