-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Accessibility: Add setting to increase scrollbar and other small control sizes #11627
Desktop: Accessibility: Add setting to increase scrollbar and other small control sizes #11627
Conversation
I would like to suggest having an option to set it to For example, I am shortsighted, but setting scrollbars to |
:root { | ||
--scrollbar-size: ${Number(options.scrollbarSize ?? 7)}px; | ||
} | ||
|
||
::-webkit-scrollbar { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to refactor this so that the ::-webkit-scrollbar
styles aren't duplicated. This can potentially be done in a follow-up pull request.
Summary
Goal: Allow users to make scrollbars meet WCAG 2.2 SC 2.5.8: Content Size (Minimum) by adding a setting to allow increasing their minimum dimension to 24px.
Note: An alternate approach — a setting that switches to system scrollbars is implemented here. However, I haven't found a simple way to increase the size of the OS scrollbars used in Joplin from system settings. For example, this Windows thread links to an article that suggests editing the registry.
Screenshots
The setting, set to the default of small (7px):
Medium (12px):
Large (24px):
Sidebar, note list, Markdown editor and viewer visible (setting enabled):
Rich Text Editor (setting enabled):
Revision viewer (setting enabled):
Notes
StyleSheetContainer
component was renamed toAppStyles
. In addition to adding style sheets to each Joplin window, the component now adds a-large-controls
CSS class to the:root
element when the large controls setting is enabled..-large-controls
class is used inmain.scss
to set the scrollbar and default checkbox size.packages/renderer
for rendered Markdown.useMarkupToHtml
hook for rendering as theNoteEditor
. This change was intended to simplify passing theincreaseControlsSize
setting to the renderer.NoteRevisionViewer
was converted from a class to a function component.To-do
packages/renderer
andpackages/app-desktop
. To these changes easier to review, it may make sense to move them to a separate pull request.Testing plan
Fedora 41: