Desktop: Accessibility: Improve scrollbar contrast #11708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Note**: Related to an issue mentioned in laurent22#11666
packages/lib/theme.ts
Outdated
| @@ -97,7 +97,49 @@ const globalStyle = (() => { | |||
| }; | |||
| })(); | |||
|
|
|||
| export function extraStyles(theme: Theme) { | |||
| export const derivedColors = (theme: Theme) => { | |||
There was a problem hiding this comment.
Since scrollbarThumbColor is used in renderer/, it needs to be available on mobile. As such, derived colors were refactored into a new derivedColors function that can be used in app-mobile's global-style.ts.
| @@ -137,14 +137,13 @@ export default function(theme: any, options: Options = null) { | |||
| border: none; | |||
| } | |||
| ::-webkit-scrollbar-thumb { | |||
| background: rgba(100, 100, 100, 0.3); | |||
| border-radius: 5px; | |||
There was a problem hiding this comment.
Note: Setting border-radius here is unnecessary (it's already set a few lines above).
The new name should clarify that derivedColors returns a copy of the given object **with** derived colors added.
|
|
||
| // Uses a scrollbar with secondary colors. Should be used for content with | ||
| // background matching joplin-background-color2. | ||
| ._scrollbar2 { |
There was a problem hiding this comment.
_scrollbar2 follows the naming pattern for RSCSS helper classes. RSCSS also suggests including all helpers in a single file called helpers. For now, _scrollbar2 is included in main.scss (near the other scrollbar logic). If desired, I can move it to a new helpers.scss file.
personalizedrefrigerator
added
desktop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request increases the scrollbar contrast, particularly in the sidebar, which has a dark background in light mode.
Fixes #8817 (which was originally fixed by #8831, though that fix was reverted).
Related to #10795 (WCAG 2.2 SC 1.4.3).
Screenshots
To-do