Desktop: Remove cancelled keys in favour of explicit keymaps #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks Caleb! And I agree an explicit list of supported commands is much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this I took the default keymap and removed any keys that didn't seem useful. I'm not claiming that this is the perfect list of supported functions, so I'm open to any input @laurent22 @tessus
Below is the keymap as it exists before this change
basic
Left: "goCharLeft"
Right: "goCharRight"
Up: "goLineUp"
Down: "goLineDown"
End: "goLineEnd"
Home: "goLineStartSmart"
PageUp: "goPageUp"
PageDown: "goPageDown"
Delete: "delCharAfter"
Backspace: "delCharBefore"
Shift-Backspace: "delCharBefore"
Tab: "defaultTab"
Shift-Tab: "indentAuto"
Enter: "newlineAndIndent"
Insert: "toggleOverwrite"
Esc: "singleSelection"
default
Ctrl-A: "selectAll"
Ctrl-D: "deleteLine"
Ctrl-Z: "undo"
Shift-Ctrl-Z: "redo"
Ctrl-Y: "redo"
Ctrl-Home: "goDocStart"
Ctrl-End: "goDocEnd"
Ctrl-Up: "goLineUp"
Ctrl-Down: "goLineDown"
Ctrl-Left: "goGroupLeft"
Ctrl-Right: "goGroupRight"
Alt-Left: "goLineStart"
Alt-Right: "goLineEnd"
Ctrl-Backspace: "delGroupBefore"
Ctrl-Delete: "delGroupAfter"
Ctrl-S: "save"
Shift-Ctrl-G: "findPrev"
Shift-Ctrl-F: "replace"
Shift-Ctrl-R: "replaceAll"
Ctrl-[: "indentLess"
Ctrl-]: "indentMore"
Ctrl-U: "undoSelection"
Shift-Ctrl-U: "redoSelection"
Alt-U: "redoSelection"
fallthrough: "basic"
macDefault
Cmd-A: "selectAll"
Cmd-D: "deleteLine"
Cmd-Z: "undo"
Shift-Cmd-Z: "redo"
Cmd-Y: "redo"
Cmd-Home: "goDocStart"
Cmd-Up: "goDocStart"
Cmd-End: "goDocEnd"
Cmd-Down: "goDocEnd"
Alt-Left: "goGroupLeft"
Alt-Right: "goGroupRight"
Cmd-Left: "goLineLeft"
Cmd-Right: "goLineRight"
Alt-Backspace: "delGroupBefore"
Ctrl-Alt-Backspace: "delGroupAfter"
Alt-Delete: "delGroupAfter"
Cmd-S: "save"
Shift-Cmd-G: "findPrev"
Cmd-Alt-F: "replace"
Shift-Cmd-Alt-F: "replaceAll"
Cmd-[: "indentLess"
Cmd-]: "indentMore"
Cmd-Backspace: "delWrappedLineLeft"
Cmd-Delete: "delWrappedLineRight"
Cmd-U: "undoSelection"
Shift-Cmd-U: "redoSelection"
Ctrl-Up: "goDocStart"
Ctrl-Down: "goDocEnd"