Mobile: Partially addresses #6615: Add alt text/roles to some (but not all!) buttons #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds accessibilityLabels to many of the app's buttons. Many buttons still lack this attrubute, however, and the app is still lacking an accessibility focus order that makes sense.
CalebJohn
reviewed
Jun 25, 2022
|
Looks good, it's always a good idea to improve the app accessibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in this PR
accessibilityLabels to many (not all) of the app's buttons.Still needs to be done (follow-up PR)
A subset of what still needs to be done (with regards to accessibility):
Testing
alttext, difficult navigation #6615 for testing instructions.