-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WEB client, add 403 retry (Fix "Video returned by Youtube is not what was requested") #88
Conversation
Maybe playlists will work with the new player params from #93 ? |
Can someone explain? I don't understand how this supersedes #93 because I don't see any file overlap 😕 What am I missing? Is the whole client being changed away from Android and that is why version is irrelevant now? |
What is there to explain? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure, but
// Android client gives encoded Base64 response to trailer which is also protobuf so we can't decode it
clientConfig = YoutubeClientConfig.WEB.copy();
Since you now use WEB we have no longer Android - or do I understand that wrong?
I don't understand what you're asking. This change will likely be superseded by my rewritten source manager once I make a release for it anyway. The entire lot has been refactored and restructured so this doesn't matter. It was just a dirty fix so we could at least release a working jar. |
Superseded by https://github.com/lavalink-devs/youtube-source Users are advised to move to that as it's likely that the built-in source manager will be deprecated soon. |
Should fix lavalink-devs/Lavalink#1030 by switching from
ANDROID
client toWEB
.To minimize the chances of encountering a 403 due to the odd invalid cipher resolving, I've implemented a basic 403 retry mechanism that will aim to fetch a new stream URL up to 3 times before throwing.