Code

Memory and rendering improvements#752

Code

Merged

ScrubN merged 44 commits intolay295:masterlay295/TwitchDownloader:masterfrom ScrubN:memory-improvementsScrubN/TwitchDownloader:memory-improvementsCopy head branch name to clipboardJul 31, 2023

+1,077-577

Commits

Commits on Jul 2, 2023

• Use more spans and references where possible, support reusing the same shaper for measuring text

  ScrubN

  committed
  9816994

  Copy full SHA for 9816994

• Don't hide the renderoptions in GetFallbackFont

  ScrubN

  committed
  0aeadfc

  Copy full SHA for 0aeadfc

• Minor cleanup

  ScrubN

  committed
  d0afd9e

  Copy full SHA for d0afd9e

Commits on Jul 3, 2023

• Debug stuff

  ScrubN

  committed
  0766aff

  Copy full SHA for 0766aff

• Implement IDisposable in several types to properly release resources

  ScrubN

  committed
  3d7d2af

  Copy full SHA for 3d7d2af

• Cache values instead of making repeated external calls

  ScrubN

  committed
  8038737

  Copy full SHA for 8038737

• Misc cleanup

  ScrubN

  committed
  c931340

  Copy full SHA for c931340

• Return highlight icon bitmap reference instead of copy

  ScrubN

  committed
  048ed57

  Copy full SHA for 048ed57

• Use precomputed emote total duration, use reverse for loop instead of reverse iterator

  ScrubN

  committed
  0e22f19

  Copy full SHA for 0e22f19

Commits on Jul 6, 2023

• Update FfmpegProcess, remove pointless couple to FfmpegProcess in DriveHelper

  ScrubN

  committed
  e273f06

  Copy full SHA for e273f06

• Fix potential memory leaks, make less repeated external calls, cache SKColor.Parse(PURPLE)

  ScrubN

  committed
  f1fc375

  Copy full SHA for f1fc375

• General cleanup

  ScrubN

  committed
  003a760

  Copy full SHA for 003a760

Commits on Jul 7, 2023

• Short circuit RemoveRestrictedComments if there are no comment restrictions, compare case insensitively instead of using string.ToLower

  ScrubN

  committed
  937b13d

  Copy full SHA for 937b13d

• More case insensitive checks instead of string.ToLower()

  ScrubN

  committed
  d2f4312

  Copy full SHA for d2f4312

• Use StringBuilder.Replace instead of String.Replace

  ScrubN

  committed
  056fb96

  Copy full SHA for 056fb96

• Do not render every previous comment when starting at comment index 101 or later

  ScrubN

  committed
  9eab936

  Copy full SHA for 9eab936

• Use a StringPool to cache frequently recreated strings, short circuit early if a message is empty

  ScrubN

  committed
  6901031

  Copy full SHA for 6901031

• Move TimeSpanExtensions.cs to TwitchDownloaderCore.Extensions

  ScrubN

  committed
  188734a

  Copy full SHA for 188734a

• Forgot to stage

  ScrubN

  committed
  90cbb34

  Copy full SHA for 90cbb34

• Add success check to TwitchEmote image decoding

  ScrubN

  committed
  783d5c3

  Copy full SHA for 783d5c3

• More descriptive unsupported chat format exception messages

  ScrubN

  committed
  6efaab2

  Copy full SHA for 6efaab2

• Use spans instead of StringPool

  ScrubN

  committed
  73534b7

  Copy full SHA for 73534b7

Commits on Jul 8, 2023

• Fix oversight, only report progress every 3 ticks (less allocations), use interpolated string handler format provider instead of ToString

  ScrubN

  committed
  48c6387

  Copy full SHA for 48c6387

• Cache the SKImageInfo for each sectionImage for less external calls, use custom TryGetTwitchEmote() methods instead of .Any() then .First()

  ScrubN

  committed
  3a0ff51

  Copy full SHA for 3a0ff51

Commits on Jul 9, 2023

• Fix a few more minor memory leaks, refactor bits checking to be faster and allocate less, cleanup

  ScrubN

  committed
  b45a320

  Copy full SHA for b45a320

Commits on Jul 11, 2023

• Reduce allocations made by TimeSpanHFormat.Format and TaskData.LengthFormatted, create ToFormattedString<T>() for custom string formatting without boxing

  ScrubN

  committed
  cd426bb

  Copy full SHA for cd426bb

Commits on Jul 12, 2023

• Use string.Create instead of a custom extension method

  Show description for ef036dc
  ScrubN

  committed
  ef036dc

  Copy full SHA for ef036dc

• Less allocations when serializing plain text chats

  ScrubN

  committed
  953dfa7

  Copy full SHA for 953dfa7

• Move GetShapedTextPath to SKPaintExtensions, cache SKPaint.GetFont reflection

  ScrubN

  committed
  241fec2

  Copy full SHA for 241fec2

Commits on Jul 13, 2023

• Use StringBuilder to build downloaded message bodies, store banned word regexes only in the needed scope, rename fields

  ScrubN

  committed
  e78fb04

  Copy full SHA for e78fb04

Commits on Jul 15, 2023

• Fix ChatRender timestamps resetting after 24 hours, make ChatRender timestamp generation almost free, make TimeSpanHFormat.Format faster and allocate less, add non-boxing overload of TimeSpanHForma…

  Show description for 83e1d4d
  ScrubN

  committed
  83e1d4d

  Copy full SHA for 83e1d4d

• Explicitly set immutable bitmaps as immutable, obey offline when fetching gift-illus.png, return SKImages from HighlightIcons

  Show description for d8f2629
  ScrubN

  committed
  d8f2629

  Copy full SHA for d8f2629

Commits on Jul 18, 2023

• Fix potential timecode parsing crash

  ScrubN

  committed
  17ae017

  Copy full SHA for 17ae017

• More efficient chat text Utc formatting

  ScrubN

  committed
  ce72e59

  Copy full SHA for ce72e59

• Merge branch 'master' into memory-improvements

  ScrubN

  authored
  8dee5b9

  Copy full SHA for 8dee5b9

Commits on Jul 25, 2023

• Merge branch 'master' into memory-improvements

  ScrubN

  committed
  86b9a01

  Copy full SHA for 86b9a01

Commits on Jul 27, 2023

• Merge branch 'master' of https://github.com/lay295/TwitchDownloader into memory-improvements

  ScrubN

  committed
  c3f6dcc

  Copy full SHA for c3f6dcc

• Cleanup

  ScrubN

  committed
  7887ac0

  Copy full SHA for 7887ac0

• Reduce GC footprint of BufferExtensions.Add

  ScrubN

  committed
  501a6c1

  Copy full SHA for 501a6c1

• Make ChatBadge bitmaps immutable

  ScrubN

  committed
  5fced45

  Copy full SHA for 5fced45

• Explicitly make local functions static

  ScrubN

  committed
  ca0c5f2

  Copy full SHA for ca0c5f2

Commits on Jul 29, 2023

• Fix message timestamp resetting after 24 hours in HTML chats and reduce memory allocated by HTML chat serializer

  ScrubN

  committed
  e8dbca2

  Copy full SHA for e8dbca2

• Fix minor spacing issue

  ScrubN

  committed
  dea9ba5

  Copy full SHA for dea9ba5

Commits on Jul 31, 2023

• Make ParseCommentBadges more readable

  ScrubN

  committed
  2352ebf

  Copy full SHA for 2352ebf