Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videodownload patch #756

Merged
merged 7 commits into from
Jul 23, 2023
Merged

Videodownload patch #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7476c9
Rewrite VOD part downloading
ScrubN Jul 16, 2023
720bc80
Fallback to non-throttled download when encountering an unexpected EOF
ScrubN Jul 16, 2023
b5a9b6e
Add video part download verification
ScrubN Jul 16, 2023
bdefa1b
Fix deadlock
ScrubN Jul 16, 2023
3222701
Restart faulted threads if possible, log encountered exceptions
ScrubN Jul 18, 2023
bee328a
Round ffmpeg percent calculation, do not report a number if percent i…
ScrubN Jul 18, 2023
e87af6d
Better video part verification process
ScrubN Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions TwitchDownloaderCLI/Modes/DownloadVideo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ internal static void Download(VideoDownloadArgs inputOptions)
{
FfmpegHandler.DetectFfmpeg(inputOptions.FfmpegPath);

var downloadOptions = GetDownloadOptions(inputOptions);

VideoDownloader videoDownloader = new(downloadOptions);
Progress<ProgressReport> progress = new();
progress.ProgressChanged += ProgressHandler.Progress_ProgressChanged;
videoDownloader.DownloadAsync(progress, new CancellationToken()).Wait();

var downloadOptions = GetDownloadOptions(inputOptions);
VideoDownloader videoDownloader = new(downloadOptions, progress);
videoDownloader.DownloadAsync(new CancellationToken()).Wait();
}

private static VideoDownloadOptions GetDownloadOptions(VideoDownloadArgs inputOptions)
Expand Down
Loading