Skip to content

Commit

Permalink
Set BUILD_LIBRARY_FOR_DISTRIBUTION to YES
Browse files Browse the repository at this point in the history
  • Loading branch information
woohyunjin06 committed Jul 22, 2023
1 parent f318774 commit d9da6d5
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
6 changes: 6 additions & 0 deletions FlexLayout.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
Expand Down Expand Up @@ -577,6 +578,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
Expand Down Expand Up @@ -638,6 +640,7 @@
24DA376F1EF843C500D1AB2F /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "";
Expand Down Expand Up @@ -673,6 +676,7 @@
24DA37701EF843C500D1AB2F /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "";
Expand Down Expand Up @@ -708,6 +712,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 2B210ECFE9D7665DACB8E8A7 /* Pods-FlexLayoutTests.debug.xcconfig */;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
DEVELOPMENT_TEAM = F37Y9H9E46;
FRAMEWORK_SEARCH_PATHS = "$(inherited)";
Expand All @@ -724,6 +729,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 38E690AA4AF8EDFC95DB6626 /* Pods-FlexLayoutTests.release.xcconfig */;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
DEVELOPMENT_TEAM = F37Y9H9E46;
FRAMEWORK_SEARCH_PATHS = "$(inherited)";
Expand Down
6 changes: 6 additions & 0 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ let package = Package(
name: "FlexLayout",
products: [
.library(name: "FlexLayout", targets: ["FlexLayout"]),
.library(name: "FlexLayoutBinary", targets: ["FlexLayoutBinary"]),
.library(name: "FlexLayoutYoga", targets: ["FlexLayoutYoga"]),
.library(name: "FlexLayoutYogaKit", targets: ["FlexLayoutYogaKit"])
],
Expand All @@ -29,6 +30,11 @@ let package = Package(
.define("FLEXLAYOUT_SWIFT_PACKAGE")
]
),
.binaryTarget(
name: "FlexLayoutBinary",
url: "https://github.com/woohyunjin06/FlexLayout/releases/download/1.3.33/FlexLayout.xcframework.zip",
checksum: "9e81b4565e20cfed0d1c15ebfda181cd068f568fb1a2d627b407e96349eafe76"
),
.target(
name: "FlexLayoutYoga",
dependencies: [],
Expand Down
2 changes: 0 additions & 2 deletions Sources/Swift/YGLayoutExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import CoreGraphics
import FlexLayoutYoga
#endif

postfix operator %

This comment has been minimized.

Copy link
@cherrythia

cherrythia Aug 14, 2023

Hi @woohyunjin06 , Thank you for this commit. Why removing this line is required for ABI to work with other swift versions? I noticed that if this line is not removed, the ABI stability will not work with other swift versions.


extension Int {
public static postfix func % (value: Int) -> YGValue {
return YGValue(value: Float(value), unit: .percent)
Expand Down

0 comments on commit d9da6d5

Please sign in to comment.