Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on redis / kredis for sudoable #124

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

javierav
Copy link
Contributor

The dependency on kredis can be eliminated by persisting the information in the database.

@lazaronixon
Copy link
Owner

lazaronixon commented Oct 24, 2024

Hey, well done. I particularly dislike sudo_at > 30 minutes ago, but since we're removing a dependency and it's the only place we're using kredis, it's worth it.

@lazaronixon lazaronixon merged commit 110f5fd into lazaronixon:main Oct 24, 2024
@javierav javierav deleted the sudoable branch October 24, 2024 15:53
@javierav
Copy link
Contributor Author

@lazaronixon an alternative may be

(30.minutes.ago..).cover?(sudo_at)

But I think is more complicated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants