Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file with GPL 2, and update README #39

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

fingolfin
Copy link
Collaborator

The README now points to the GitHub issue tracker, states the
license, and uses Markdown sections.

Resolves #33

@gaehler
Copy link
Collaborator

gaehler commented Nov 4, 2019

You may want to replace, in the license file, all ocurrencies of NormalizInterface by CARAT. Apart from that, I appreciate this PR. This is then probably a good point to wrap the thing and publish a new release of my GAP package Carat. Or should I wait for further cleanup? I do not want to miss GAP 4.11.

The README now points to the GitHub issue tracker, states the
license, and uses Markdown sections.
@fingolfin
Copy link
Collaborator Author

Oops, that was a stupid mistake. Fixed the LICENSE file.

As to making a release: yes, we should get this into GAP 4.11, on which @alex-konovalov is working right now (so we should coordinate with him). That said, of course it'd be kinda nice if the new build system got in as well (see PR #36); then again, since that is a fairly big change, and may require changes in the GAP package carat as well, maybe that's actually a reason to make a release first (to have a stable reference), and only then merge PR #36 (which is not quite ready right now anyway).

As a sort of middle ground, I could put the warning fixes and other code tweaks from PR #36 into a separate PR.

@gaehler
Copy link
Collaborator

gaehler commented Nov 4, 2019

I would say that I should publish a new release including all low hanging fruit soon, to be sure not to miss the train for GAP 4.11. @alex-konovalov: what is the schedule for GAP 4.11? When the rest gets ready in time, too, I can still make another release.

Copy link
Collaborator

@gaehler gaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine with me now.

Copy link
Collaborator

@DominikBernhardt DominikBernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fingolfin !

@DominikBernhardt DominikBernhardt merged commit 10292cb into lbfm-rwth:master Nov 5, 2019
@fingolfin fingolfin deleted the mh/license branch November 5, 2019 06:20
@olexandr-konovalov
Copy link
Collaborator

olexandr-konovalov commented Nov 6, 2019

@gaehler @fingolfin I'd like to finalise packages for GAP 4.11 ASAP - realistically, next couple of weeks. I really want to get 4.11 out this year, and not to do it on the last working week of December ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore COPYING
4 participants